[LTP] [PATCH 2/2] runtest: ltp-aiodio.part2: Limit the maximal filesize

[Jan Kara]

On Fri 20-03-26 10:51:27, Cyril Hrubis wrote:
> Hi!
> > > The test was operating with filesize up to ~500MB which, in certain
> > > cases, was making the runtime too slow. Some test variants, especially
> > > with many processes, were running up to 15 mintues on modern hardware.
> > > After a discussion we agreed that we can reduce the maximal file size to
> > > one quater without sacrificing test coverage.
> > > 
> > > I've also assumed that there was a typo in ADSP072 since the buffer size
> > > was set to be order of magnitude bigger than the file size.
> > > 
> > > CC: Jan Kara <jack@suse.cz>
> > > Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> > > ---
> > >  runtest/ltp-aiodio.part2 | 16 ++++++++--------
> > >  1 file changed, 8 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/runtest/ltp-aiodio.part2 b/runtest/ltp-aiodio.part2
> > > index 599c9fd2f..c82f6fd02 100644
> > > --- a/runtest/ltp-aiodio.part2
> > > +++ b/runtest/ltp-aiodio.part2
> > > @@ -25,8 +25,8 @@ ADSP023 aiodio_sparse -o 4 -w 1024k -s 4096k -n 6
> > >  ADSP024 aiodio_sparse -o 4 -w 2048k -s 8192k -n 6
> > >  ADSP025 aiodio_sparse -o 4 -w 4096k -s 16384k -n 6
> > >  ADSP026 aiodio_sparse -o 4 -w 18192k -s 72768k -n 6
> > > -ADSP027 aiodio_sparse -o 4 -w 18192k -s 518192k -n 6
> > > -ADSP028 aiodio_sparse -o 4 -w 65536k -s 262144k -n 6
> > > +ADSP027 aiodio_sparse -o 4 -w 18192k -s 129548k -n 6
> > > +ADSP028 aiodio_sparse -o 4 -w 65536k -s 129548k -n 6
> > 
> > I think the write size of 64MB is too large for 128MB file with 4 AIO
> > contexts - I think the size will be autotrimmed to 32MB. So you might as
> > well just specify -w 32768k.
> 
> Right, will fix that.
> 
> > Otherwise this looks good to me.
> 
> Do I need to send v2 or can I add your Reviewed-by: if I fix the write
> size before applying the patches?

Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

one that one is fixed.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR