[LTP] [Valgrind-developers] [RFC PATCH 1/1] LTP tests: Run without LTP_REPRODUCIBLE_OUTPUT=1
Martin Cermak
mcermak@redhat.com
Wed Mar 25 10:21:56 CET 2026
On Wed 2026-03-25 10:10 , Petr Vorel wrote:
> > On Tue 2026-03-24 15:09 , Martin Cermak wrote:
> > > On Tue 2026-03-24 14:18 , Cyril Hrubis wrote:
> > > > Hi!
> > > > > LTP_REPRODUCIBLE_OUTPUT=1 environment variable was added in 5894abc5f to
> > > > > help valgrind to use LTP for testing. It discards the actual content of
> > > > > the messages printed by the test (removes everything after printing
> > > > > TINFO/TPASS/TFAIL/... flag).
>
> > > > > Later LTP_QUIET=1 was added which suppresses printing TCONF, TWARN,
> > > > > TINFO, and TDEBUG messages. Therefore LTP_REPRODUCIBLE_OUTPUT=1 is not
> > > > > needed any more.
>
> > > > I do not think so. We still have things like pids and timestamps in
> > > > TPASS/TFAIL messages that needs to be removed in order for the output to
> > > > be reproducible.
>
> > > From Valgrind persp, seems like we could drop it at the first
> > > glance. But let me confirm that based on a thorough check.
>
> > My quick guess above was wrong. We do need
> > LTP_REPRODUCIBLE_OUTPUT for Valgrind testing.
> > Please keep it.
>
> Thanks for info, Martin. Sure, please drop this patch.
>
> I still feel these 2 variables somehow overlap, wouldn't it make sense to merge
> the functionality into a single variable?
That sounds reasonable to me. Which one would you prefer to
keep? I'm inclined to suggest keeping LTP_REPRODUCIBLE_OUTPUT
and dropping LTP_QUIET but no really strong preference on my
side. Thoughts?
Martin
More information about the ltp
mailing list