[LTP] [PATCH] userfaultfd: Minor fixes

Petr Vorel pvorel@suse.cz
Wed Mar 25 10:23:13 CET 2026


Hi Ricardo,

...
> +++ b/testcases/kernel/syscalls/userfaultfd/userfaultfd01.c
> @@ -53,11 +53,14 @@ static void set_pages(void)

>  static void reset_pages(void)
>  {
> -	SAFE_MUNMAP(page, page_size);
> -	SAFE_MUNMAP(copy_page, page_size);
> +	if (page) {
> +		SAFE_MUNMAP(page, page_size);
> +		SAFE_MUNMAP(copy_page, page_size);
> +		page = NULL;
> +	}
>  }

> -static void *handle_thread(void)
> +static void *handle_thread(void *arg LTP_ATTRIBUTE_UNUSED)
>  {
>  	static struct uffd_msg msg;
>  	struct uffdio_copy uffdio_copy = {};
> @@ -129,4 +132,5 @@ static struct tst_test test = {
>  	.setup = setup,
>  	.test = run,
>  	.tcnt = ARRAY_SIZE(tcases),
> +	.cleanup = reset_pages,
>  };
> diff --git a/testcases/kernel/syscalls/userfaultfd/userfaultfd02.c b/testcases/kernel/syscalls/userfaultfd/userfaultfd02.c
> index 2fd5ba5d8..db9ce4da4 100644
> --- a/testcases/kernel/syscalls/userfaultfd/userfaultfd02.c
> +++ b/testcases/kernel/syscalls/userfaultfd/userfaultfd02.c
> @@ -32,11 +32,13 @@ static void set_pages(void)

>  static void reset_pages(void)
>  {
> -	SAFE_MUNMAP(page, page_size);
> -	SAFE_MUNMAP(move_page, page_size);
> +	if (page) {
> +		SAFE_MUNMAP(page, page_size);
> +		SAFE_MUNMAP(move_page, page_size);
Here should be also page = NULL; right?

With that (can be added before merge)
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> +	}
>  }
...


More information about the ltp mailing list