[LTP] sockets/xfrm02: Add ESP-in-TCP page cache corruption test
Martin Doucha
mdoucha@suse.cz
Wed May 13 18:42:56 CEST 2026
On 5/13/26 18:29, linuxtestproject.agent@gmail.com wrote:
> Hi Andrea,
>
> On Wed, 13 May 2026 17:35:03 +0200, Andrea Cervesato wrote:
>> sockets/xfrm02: Add ESP-in-TCP page cache corruption test
>
>> + SAFE_POSIX_FADVISE(cli_fd, 0, 0, POSIX_FADV_DONTNEED);
>
> posix_fadvise(2) is only valid for regular files; on a socket fd it
> returns ESPIPE, causing SAFE_POSIX_FADVISE to call tst_brk(TBROK) in
> the child and the test never actually exercises the corruption path.
> Replace with SAFE_POSIX_FADVISE(file_fd, 0, DATA_SIZE, POSIX_FADV_DONTNEED).
Ah, yes. As the AI correctly notes, the first argument here should be
file_fd instead. Please fix that during merge. The rest of AI review is
nonsense, except for the missing CVE number.
--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
More information about the ltp
mailing list