[LTP] thermal: add new test group
linuxtestproject.agent@gmail.com
linuxtestproject.agent@gmail.com
Thu May 14 16:19:12 CEST 2026
Hi Piotr,
On Thu, 14 May 2026 15:34:47 +0200, Piotr Kubaj wrote:
> thermal: add new test group
> + while (sleep_time > 0) {
> + ...
> + if (temp > temp_high)
> + break;
> + sleep(sleep_time--);
G2: sleep() used for synchronization. This is not a timer API test so
the G2 exemption does not apply. Consider polling with
tst_timer_expired_ms() or discuss with maintainers if a thermal-specific
exception is appropriate.
> + tst_res(TINFO, "Cooling down for %d seconds", COOLDOWN);
> + sleep(COOLDOWN);
G2: Same issue — sleep() used as a synchronization barrier for CPU
cooldown between zone tests. If a non-sleep alternative is genuinely
infeasible for thermal testing, this needs explicit justification in the
commit message.
---
Note:
Our agent completed the review of the patch. The agent can sometimes
produce false positives although often its findings are genuine. If you
find issues with the review, please comment this email or ignore the
suggestions.
Regards,
LTP AI Reviewer
More information about the ltp
mailing list