[LTP] futex_wait06: Add EFAULT error coverage test

linuxtestproject.agent@gmail.com linuxtestproject.agent@gmail.com
Mon May 25 19:13:00 CEST 2026


Hi Michael,

On Mon, 25 May 2026 17:44:14 +0300, Michael Menasherov wrote:
> [PATCH 1/4] futex_wait06: Add EFAULT error coverage test

--- [PATCH 1/4] ---

> +static struct futex_test_variants variants[] = {
> +#if (__NR_futex != __LTP__NR_INVALID_SYSCALL)
> +	{ .fntype = FUTEX_FN_FUTEX, .tstype = TST_KERN_OLD_TIMESPEC, .desc = "syscall with old kernel spec"},
> +#endif
> +
> +#if (__NR_futex_time64 != __LTP__NR_INVALID_SYSCALL)
> +	{ .fntype = FUTEX_FN_FUTEX64, .tstype = TST_KERN_TIMESPEC, .desc = "syscall time64 with kernel spec"},
> +#endif
> +};

`.tstype` is set here but `run()` calls `futex_syscall()` directly without
ever reading `tv->tstype`. Since the test passes the raw bad pointer as
timeout (bypassing `tst_ts_*`), drop the `.tstype` assignments from
both variants — they are dead and misleading.

[...]

--- [PATCH 4/4] ---

> +futex_cmp_requeue03 futex_cmp_requeue03

This entry is placed after `futex_wake05` rather than near the other
`futex_cmp_requeue` entries. It should follow `futex_cmp_requeue02`
at line 1865.

[...]

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/26411600640

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer


More information about the ltp mailing list