[LTP] zram01: Specify filesystem type explicitly in mount

Petr Vorel pvorel@suse.cz
Tue May 26 09:18:38 CEST 2026


> Hi Avinesh,

> On Mon, 25 May 2026 21:01:23 +0200, Avinesh Kumar wrote:
> > zram01: Specify filesystem type explicitly in mount

> > -	for i in $(seq $dev_start $dev_end); do
> > -		tst_res TINFO "mount /dev/zram$i"
> > +	local i=$dev_start
> > +	local fs
> > +
> > +	for fs in $zram_filesystems; do
> > +		tst_res TINFO "mount /dev/zram$i ($fs)"
> >  		mkdir zram$i
> > -		ROD mount /dev/zram$i zram$i
> > +		ROD mount -t "$fs" /dev/zram$i zram$i
> >  		dev_mounted=$i
> > +		i=$((i + 1))
> >  	done

> Nit: the rest of the file uses `$(($i + 1))` (e.g. zram_makefs). Prefer
> `i=$(($i + 1))` here for consistency.

Good catch, but I'd prefer to use the form Avinesh posted (i.e. "i", not "$i").
And it's probably not worth to do the cleanup on the other place (neither in
this commit nor in the separate).

Kind regards,
Petr


More information about the ltp mailing list