[LTP] build: Fix library prerequisites in testcases.mk

linuxtestproject.agent@gmail.com linuxtestproject.agent@gmail.com
Tue Oct 20 21:04:50 CEST 2026


Hi Andrea,

On 20 October 2026, Andrea Cervesato wrote:
> [PATCH 1/3] build: Fix library prerequisites in testcases.mk

--- [PATCH 2/3] ---

> diff --git a/include/mk/generic_trunk_target.inc b/include/mk/generic_trunk_target.inc
> +MAKE_DEPS += $(abs_top_builddir)/lib/libltp.a $(abs_top_builddir)/libs-all

Medium: testcases/lib already has a per-library ujson prerequisite, so
when ujson needs rebuilding, make -j4 -C testcases/lib tst_run_shell
launches that builder alongside libs-all's ujson builder. Both write the
same objects and libujson.a concurrently, allowing a corrupt archive or
a failed link. Serialize or deduplicate these prerequisite paths so each
library has only one builder.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer


More information about the ltp mailing list