[LTP] [PATCH v3] inotify13: check rename cookie pairing after adjacent moves

[Amir Goldstein]

On Thu, Oct 29, 2026 at 9:23 PM Hungyu Lin <dennylin0707@gmail.com> wrote:
>
> Following up on my earlier reply, I'd like to confirm that I've understood
> your feedback correctly before sending v4.
>
> Below are example outputs for the seven failure diagnostics.
>
> 1. Extra event
>
>     file: got unnecessary event 3: mask=0x40 wd=1 cookie=123 len=16 name="entry"
>
> 2. Wrong event mask
>
>     file: got event 1: mask=0x80 (expected 0x40) wd=2 cookie=123 name="entry"
>
> 3. Wrong watch descriptor
>
>     file: got event 0: mask=0x40 wd=2 (expected 1) cookie=123 name="entry"
>
> 4. Wrong filename
>
>     file: got event 0: mask=0x40 wd=1 cookie=123 len=16 name="other"
> (expected "entry")
>
> 5. Missing event
>
>     file: didn't get event 2: mask=0x80 wd=2 name="entry"
>
> 6. Identical cookies for the two FROM events
>
>     file: got second FROM cookie=123 (expected != 123), wd=1 mask=0x40
> name="entry"
>
> 7. Mismatched cookies for the second FROM/TO pair
>
>     file: got TO cookie=125 (expected 124 from second FROM), wd=2
> mask=0x80 name="entry"
>
> Do these follow the pattern you meant?

Yes, perfect.

> In particular, would you omit any
> of the additional event context, such as wd or cookie in the mask-mismatch
> message?

I would keep the event context in 1-4 because that is the common practice
and because in this case the INFO is not printed.

I would omit the event context in 6,7 because it is already present
in the INFO message and irrelevant to the error.

>
> I'd appreciate your feedback before I send v4.

Good idea. I should have led with examples.

Thanks,
Amir.