[LTP] fsconfig04: Check FSCONFIG_SET_PATH
linuxtestproject.agent@gmail.com
linuxtestproject.agent@gmail.com
Wed Sep 9 10:00:52 CEST 2026
Hi Wei,
On Wed Sep 9 03:34:31 2026 +0000, Wei Gao via ltp wrote:
> fsconfig04: Check FSCONFIG_SET_PATH
> +#define MNTPOINT "mntpoint"
The test does not mount a filesystem. Remove MNTPOINT and .mntpoint.
> +static struct tst_test test = {
> + .test_all = run,
> + .setup = setup,
> + .cleanup = cleanup,
> + .needs_root = 1,
> + .needs_device = 1,
> + .mntpoint = MNTPOINT,
> + .needs_cmds = (struct tst_cmd []) {
> + {.cmd = "tune2fs"},
> + {}
> + },
> + .filesystems = (struct tst_fs []) {
> + {.type = "ext3"},
> + {.type = "ext4"},
> + {}
> + },
> +};
Add .needs_tmpdir = 1 since setup() creates backing files for the loop
devices via tst_prealloc_file(). Also remove .mntpoint = MNTPOINT.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
More information about the ltp
mailing list