[LTP] lib/tst_uid: Remove spurious TERRNO from tst_get_free_gid success path
linuxtestproject.agent@gmail.com
linuxtestproject.agent@gmail.com
Fri Sep 18 14:57:44 CEST 2026
Hi Wei,
On Fri Sep 18 07:52:21 2026 +0000, Wei Gao via ltp <ltp@lists.linux.it> wrote:
> lib/tst_uid: Remove spurious TERRNO from tst_get_free_gid success path
--- [PATCH 3/3] ---
> +/*\
> + * Verify restricted opening (:manpage:`open(2)` and :manpage:`openat(2)`) of
> + * FIFOs and regular files in sticky directories. This protection is controlled via
> + * `/proc/sys/fs/protected_fifos` and `/proc/sys/fs/protected_regular` sysctl values:
> + *
> + * - When set to "0", writing/opening is unrestricted.
> + * - When set to "1", O_CREAT open on FIFOs/regular files we don't own in world-writable
> + * sticky directories is disallowed, unless they are owned by the owner of the directory.
> + * - When set to "2", the same restriction also applies to group-writable sticky directories.
> + *
> + * This test requires root to modify /proc/sys/fs/protected_* sysctls and
> + * to manage file ownership and permissions in sticky directories.
> + */
Use double backticks (``...``) for inline literals in the reST description
block instead of single backticks or unquoted text:
``/proc/sys/fs/protected_fifos``, ``/proc/sys/fs/protected_regular``, and
``/proc/sys/fs/protected_*``.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
More information about the ltp
mailing list