[pxc] smp 2.4.x oops
Alessandro Rubini
rubini@gnu.org
Tue, 11 Sep 2001 16:33:19 +0200
Hi.
> For what it is worth, I had a problem when I put 2 PCI PXC200 cards and
> a US Robotics PCI Modem on the same uniprocessor system. The modem and
> one PXC200 card wound up sharing an interrupt.
Yes, interrupt sharing didn't quite work. It was fixed here (cvs log):
revision 1.38
date: 2001/06/22 16:53:19; author: rubini; state: Exp; lines: +2 -2
keep silent for share interrupts (thanks Espen Halsaa Albrektsen)
This is just before 0.30-beta. You can apply the patch to an earlier version
if you want:
RCS file: /data/cvs/pxc/Attic/main.c,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -d -r1.37 -r1.38
--- main.c 2001/06/22 16:42:27 1.37
+++ main.c 2001/06/22 16:53:19 1.38
@@ -444,8 +444,8 @@
PDEBUG("\n");
/* This is a shared handler: if not ours, return */
status = PX_READ32(dev, BT848_INT_STAT);
- if ( status == 0) {
- PDEBUG("isr: irq %i: not mine\n",irq);
+ if ( (status & PX_DEFAULT_IRQ_MASK) == 0) {
+ PDEBUGG("isr: irq %i: not mine\n",irq);
return;
}
>
> While I'm here, I'll suggest a change to pxc_live .
> The line
> set imgfile /tmp/bla.pgm
>
> sets the name of an intermediate file to a constant value. That means
that we have a serious security error. I'm going to fix it using
mktemp as it should have been forever
/alessandro