[LTP] [PATCH v2 2/2] Increase default appends operations in dio_append

Cyril Hrubis chrubis@suse.cz
Wed Jan 31 11:30:55 CET 2024


Hi!
> I'm ok to keep this in single commit with increasing the number of operations,
> but it should have been at least mentioned in the commit message.

The commit changelog should mention the addition of the function to
check the available space, but otherwise it's ok.

> And, if I understand correctly, this was meant by Cyril in v1
> https://lore.kernel.org/ltp/ZbjpATp6cK9AkvBm@yuki/

I mostly object to having two unrelated chnages in a single commit,
functional fix shouldn't be cobbled togegher with a change that adjusts
default parameters.

Also the check for a free space should be ideally added into all I/O
tests eventually.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list