[LTP] [PATCH v2 2/2] Increase default appends operations in dio_append

Petr Vorel pvorel@suse.cz
Wed Jan 31 11:33:47 CET 2024


> Hi!
> > I'm ok to keep this in single commit with increasing the number of operations,
> > but it should have been at least mentioned in the commit message.

> The commit changelog should mention the addition of the function to
> check the available space, but otherwise it's ok.

> > And, if I understand correctly, this was meant by Cyril in v1
> > https://lore.kernel.org/ltp/ZbjpATp6cK9AkvBm@yuki/

> I mostly object to having two unrelated chnages in a single commit,
> functional fix shouldn't be cobbled togegher with a change that adjusts
> default parameters.

I figured that out, that's why I merged before you wrote. I'm sorry for the
noise.

> Also the check for a free space should be ideally added into all I/O
> tests eventually.

+1

Kind regards,
Petr


More information about the ltp mailing list