[gpm]Synaptic giant patch

[Ben Pfaff]

Peter Berg Larsen <pebl@math.ku.dk> writes:

> On 12 Aug 2002, Ben Pfaff wrote:
> 
> > > When you say that the touchpad does not work, do you mean not
> > > at all or you cannot not tap?
> > 
> > Well, before adding the tab patch and turning on
> > stick_pressure_enabled, it did nothing at all, not the touchpad
> > itself or its buttons.  Now the touchpad works fine, I can even
> > double-tap-and-drag, but the touchpad buttons still don't do
> > anything.
> 
> I have looked at it again, and I can not produce a state (manually setting
> capacities, configs, etc.) where the touchpad and its buttons dont do
> anything. Does toggling the stick_pressure_enabled toggle the behaviour?
> 
> Do your config file vary much from the default values?

No, I use the file included in CVS plus the Synaptics patch, plus
I fix the spelling of touch_pad_enabled (remove first _) and add
the line "[stick_pressure_enabled] TRUE".

However, I do have a patch against CVS + giant patch that makes
everything work okay for me:

--- /root/gpm.synaptics/src/synaptics.c	Thu Aug 15 23:39:37 2002
+++ synaptics.c	Thu Aug 15 23:29:46 2002
@@ -1413,8 +1413,9 @@
   	tmp_buttons  = ((data[1] & 0x01) ? GPM_B_LEFT   : 0);
   	tmp_buttons |= ((data[1] & 0x04) ? GPM_B_MIDDLE : 0);
   	tmp_buttons |= ((data[1] & 0x02) ? GPM_B_RIGHT  : 0);
-	tp_process_repeating_actions(state,tmp_buttons,last_stick_buttons,
-				     &last_stick_button_actions[0],stick_actions);
+	state->buttons |= tmp_buttons;
+	/*tp_process_repeating_actions(state,tmp_buttons,last_stick_buttons,
+				     &last_stick_button_actions[0],stick_actions);*/
       } 
 
       last_stick_buttons = tmp_buttons;

I suspect that there's something wrong in the
tp_process_repeating_actions() logic?
-- 
"It takes a certain amount of shamelessness
 to be a monomaniac billionaire dwarf."
--Jon Katz <URL:http://slashdot.org/articles/99/03/17/1634238.shtml>