[gpm]Synaptic giant patch

[Peter Berg Larsen]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

--0-694662011-1029499980=:18650
Content-Type: TEXT/PLAIN; charset=US-ASCII

On 15 Aug 2002, Ben Pfaff wrote:

> > > Well, before adding the tab patch and turning on
> > > stick_pressure_enabled, it did nothing at all, not the touchpad
> > > itself or its buttons.  Now the touchpad works fine, I can even
> > > double-tap-and-drag, but the touchpad buttons still don't do
> > > anything.

Does toggeling stick_pressure_enabled really alters the behaviour?


> However, I do have a patch against CVS + giant patch that makes
> everything work okay for me:

>    	tmp_buttons |= ((data[1] & 0x02) ? GPM_B_RIGHT  : 0);
> -	tp_process_repeating_actions(state,tmp_buttons,last_stick_buttons,
> -				     &last_stick_button_actions[0],stick_actions);
> +	state->buttons |= tmp_buttons;
> +	/*tp_process_repeating_actions(state,tmp_buttons,last_stick_buttons,
> +				     &last_stick_button_actions[0],stick_actions);*/
>        } 

This patch has the disadvantage that it does not allow for userdefined
behaviour. Of cause it has the small advantage that it works :)

Could you try the attached patch and send me the "stick buttons: " output?

> I suspect that there's something wrong in the
> tp_process_repeating_actions() logic?

I tend to believe that our setups differ.


Peter
--
E-Mail:       pebl@math.ku.dk 
Real name:    Peter Berg Larsen 
Where:        Department of Computer Science, Copenhagen Uni., Denmark

--0-694662011-1029499980=:18650
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=diff_ben
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.OSF.4.21.0208161413000.18650@gram.math.ku.dk>
Content-Description: 
Content-Disposition: attachment; filename=diff_ben

LS0tIHN5bmFwdGljc18yLmMJTW9uIEF1ZyAxMiAwMTo0NToyNyAyMDAyDQor
Kysgc3luYXB0aWNzLmMJRnJpIEF1ZyAxNiAxMzoyNDo1NSAyMDAyDQpAQCAt
MzExLDkgKzMxMSw5IEBADQogLyoNCiAqKiBEZWZpbmUgdGhlIGFjdGlvbiBi
dXR0b24gYml0IHZhbHVlcy4NCiAqLw0KLSNkZWZpbmUgTEVGVF9CVVRUT04g
ICAgICAgICAweDAxDQotI2RlZmluZSBSSUdIVF9CVVRUT04gICAgICAgIDB4
MDINCi0jZGVmaW5lIE1JRERMRV9CVVRUT04gICAgICAgMHgwNA0KKyNkZWZp
bmUgUklHSFRfQlVUVE9OICAgICAgICAweDAxDQorI2RlZmluZSBNSURETEVf
QlVUVE9OICAgICAgIDB4MDINCisjZGVmaW5lIExFRlRfQlVUVE9OICAgICAg
ICAgMHgwNA0KICNkZWZpbmUgRk9VUlRIX0JVVFRPTiAgICAgICAweDA4DQog
I2RlZmluZSBVUF9CVVRUT04gICAgICAgICAgIDB4MTANCiAjZGVmaW5lIERP
V05fQlVUVE9OICAgICAgICAgMHgyMA0KQEAgLTQwNCw3ICs0MDQsNyBAQA0K
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAq
IHNhbWUgZGV2aWNlIHBvcnQuIFRoZSBzdGljayB3aWxsIGJlIGlnbm9yZWQg
aW4NCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgKiBhYnNvbHV0ZSBtb2RlLCB0aGlzIG9wdGlvbiB0cnkgdG8gcmVjb2du
aXplDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICogaXQncyBwYWNrZXRzLiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgQyovDQotc3RhdGljIGludCAgIHN0aWNrX3ByZXNz
dXJlX2VuYWJsZWQgID0gMDsgLyogQSAoaGFyZCkgcHJlc3Mgb24gdGhlIHN0
aWNrIGlzIHJlcG9ydGVkIGFzIGxlZnQgY2xpY2sgQyovDQorc3RhdGljIGlu
dCAgIHN0aWNrX3ByZXNzdXJlX2VuYWJsZWQgID0gMTsgLyogQSAoaGFyZCkg
cHJlc3Mgb24gdGhlIHN0aWNrIGlzIHJlcG9ydGVkIGFzIGxlZnQgY2xpY2sg
QyovDQogc3RhdGljIGludCAgIGZvdXJfd2F5X2J1dHRvbl9lbmFibGVkID0g
MTsgLyogUm91bmQgYnV0dG9uIGdpdmluZyA0IGNob2ljZXMgb24gc29tZSB0
b3VjaHBhZHMgICAgICAgIEMqLw0KIHN0YXRpYyBpbnQgICBmb3VyX3dheV9i
dXR0b25faXNfbW91c2U9IDE7IC8qIElzIHRoZSBidXR0b246IDQgYnV0dG9u
cyBvciBkb2VzIGl0IG1vdmVzIHRoZSBtb3VzZS4gIEMqLw0KIHN0YXRpYyBp
bnQgICBzY3JvbGxpbmdfZW5hYmxlZCAgICAgICA9IDE7IC8qIFNpbXVsYXRl
IHdoZWVsIG1vdXNlIGluIGF0IHRoZSByaWdodCBlZGdlICAgICAgICAgICAg
IEMqLw0KQEAgLTE0MTgsNiArMTQxOSwxMiBAQA0KICAgCXRtcF9idXR0b25z
IHw9ICgoZGF0YVsxXSAmIDB4MDIpID8gR1BNX0JfUklHSFQgIDogMCk7DQog
CXRwX3Byb2Nlc3NfcmVwZWF0aW5nX2FjdGlvbnMoc3RhdGUsdG1wX2J1dHRv
bnMsbGFzdF9zdGlja19idXR0b25zLA0KIAkJCQkgICAgICZsYXN0X3N0aWNr
X2J1dHRvbl9hY3Rpb25zWzBdLHN0aWNrX2FjdGlvbnMpOw0KKw0KKwlncG1f
cmVwb3J0IChHUE1fUFJfREVCVUcsIlN0aWNrIGJ1dHRvbnM6ICVYICVYICVY
ICAgICVYICVYICVYIiwNCisJCSAgICBzdGF0ZS0+YnV0dG9ucyx0bXBfYnV0
dG9ucyxsYXN0X3N0aWNrX2J1dHRvbnMsDQorCQkgICAgbGFzdF9zdGlja19i
dXR0b25fYWN0aW9uc1swXSwNCisJCSAgICBsYXN0X3N0aWNrX2J1dHRvbl9h
Y3Rpb25zWzFdLA0KKwkJICAgIGxhc3Rfc3RpY2tfYnV0dG9uX2FjdGlvbnNb
Ml0pOw0KICAgICAgIH0gDQogDQogICAgICAgbGFzdF9zdGlja19idXR0b25z
ID0gdG1wX2J1dHRvbnM7DQo=
--0-694662011-1029499980=:18650--