[LTP] [PATCH v4] syscalls/statx: Add test for sync flags

vaishnavi.d vaishnavi.d@zilogic.com
Wed Dec 12 13:33:04 CET 2018


Hi,

>> + * Minimum kernel version required is 4.16.
> statx() was merged into 4.11 in commit a528d35e8bfc ("statx: Add a system
> call
> to make enhanced file info available" as you had in v1. Why now requiring
> 4.16?
> It looks like second test fails now on 4.11, because calling get_mode()
> for it
> as well (see bellow).

Actually, support for sync flags was added only from kernel version 4.16.
Since, I was using 4.16, I didn't face that issue. Thats why minimum kernel
version has been updated to 4.16 in the patch v5.
(https://github.com/torvalds/linux/commit/9ccee940bd5b766b6dab6c1a80908b9490a4850d)



>> +#include "old_tmpdir.h"
> I think, we don't want to use old_*.h headers (although library itself
> lib/tst_test.c uses it). IMHO previous version with getcwd() was better.
>

The function get tempdir will be ported to the new library soon. So, I
have not modified that part. Other changes have been made in patch v5.

Regards,
Vaishnavi D



More information about the ltp mailing list