[LTP] [PATCH v4] syscalls/statx: Add test for sync flags

Petr Vorel pvorel@suse.cz
Thu Dec 13 17:37:11 CET 2018


Hi Vaishnavi,

> Actually, support for sync flags was added only from kernel version 4.16.
> Since, I was using 4.16, I didn't face that issue. Thats why minimum kernel
> version has been updated to 4.16 in the patch v5.
> (https://github.com/torvalds/linux/commit/9ccee940bd5b766b6dab6c1a80908b9490a4850d)
Thanks for update.

> >> +#include "old_tmpdir.h"
> > I think, we don't want to use old_*.h headers (although library itself
> > lib/tst_test.c uses it). IMHO previous version with getcwd() was better.

> The function get tempdir will be ported to the new library soon. So, I
> have not modified that part. Other changes have been made in patch v5.
Good, I noticed Cyril's intention to fix the headers. We'll just wait for it and
remove import old_tmpdir.h before merging v5.

> Regards,
> Vaishnavi D

Kind regards,
Petr


More information about the ltp mailing list