[LTP] [PATCH 1/1] syscalls/fanotify10: Require kernel v4.19

Sasha Levin sashal@kernel.org
Tue Nov 6 18:46:41 CET 2018


On Tue, Nov 06, 2018 at 03:32:33PM +0200, Amir Goldstein wrote:
>On Tue, Nov 6, 2018 at 3:06 PM Petr Vorel <pvorel@suse.cz> wrote:
>>
>> Hi Amir,
>>
>> > There must be some confusion.
>> > FAN_MARK_MOUNT was NOT added in v4.19-rc2.
>> > It has been there from the start.
>> > FAN_MARK_INODE was NOT added either
>> > the define FAN_MARK_INODE  0 is just a convenience readability define
>> > it does not change the API.
>> I'm sorry, you're right.
>>
>> > You may be confusing with FAN_MARK_FILESYSTEM
>> > just was just added in kernel v4.20-rc1.
>> > The extension of tests to cover FAN_MARK_FILESYSTEM
>> > is waiting in my queue:
>> > https://github.com/amir73il/ltp/commits/fanotify_sb
>>
>> > And it already includes runtime checks for FAN_MARK_FILESYSTEM
>> > support.
>>
>> > Did I miss anything?
>> Testing your branch on older kernel, fanotify10 fails earlier than new TCONF
>
>Because fanotify10 checks for a bug that existed since the beginning
>and fixed by 9bdda4e9cf2d fsnotify: fix ignore mask logic in fsnotify().
>So test SHOULD fail until the backported patch is applied to the old kernel.
>
>The patch does not apply cleanly to kernels <= v4.17.
>Tested backport patch for v4.14.y attached.

Queued for 4.14, thanks Amir.

--
Thanks,
Sasha


More information about the ltp mailing list