[LTP] [PATCH] syscalls/copy_file_range02: skip new error tests if cross-fs isn't supported

Petr Vorel pvorel@suse.cz
Fri Oct 25 10:37:38 CEST 2019


Hi Xu,

> We should not skip the whole error test if cross-fs isn't support because
> old errors should be tested on all version. Even we use .mount_device = 1
> and .mntpoint = MNTPOINT, the src and dest file are still in tmp directory
> instead of mntpoint.

> ps: I doubt whether we should skip new error test because it indeed exposed this
> unreasonable copy_file_range behavior of the user.

> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Tested-by: Petr Vorel <pvorel@suse.cz>

LGTM, but I'd like to have Amir's review/ack.

Kind regards,
Petr


More information about the ltp mailing list