[LTP] [PATCH] syscalls/copy_file_range02: skip new error tests if cross-fs isn't supported

Amir Goldstein amir73il@gmail.com
Fri Oct 25 12:15:03 CEST 2019


On Fri, Oct 25, 2019 at 11:37 AM Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Xu,
>
> > We should not skip the whole error test if cross-fs isn't support because
> > old errors should be tested on all version. Even we use .mount_device = 1
> > and .mntpoint = MNTPOINT, the src and dest file are still in tmp directory
> > instead of mntpoint.
>
> > ps: I doubt whether we should skip new error test because it indeed exposed this
> > unreasonable copy_file_range behavior of the user.
>
> > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Tested-by: Petr Vorel <pvorel@suse.cz>
>
> LGTM, but I'd like to have Amir's review/ack.
>

ACK. I'm fine with the test code.
If you tested it and it passed on both new and old kernel,
it's fine by me.

Thanks,
Amir.


More information about the ltp mailing list