[LTP] [PATCH] syscalls/acct02: Check read size.

Petr Vorel pvorel@suse.cz
Thu Oct 31 10:09:34 CET 2019


Hi Jan,

> > How much time of the ac_btime shaking to be tolerated is proper?

> I wanted to go with 1 sec:

> @@ -83,7 +83,7 @@ static int verify_acct(void *acc, int elap_time)
>                 ret = 1;
>         }

> -       if (ACCT_MEMBER(ac_btime) < start_time) {
> +       if (ACCT_MEMBER(ac_btime) + 1 < start_time) {
>                 tst_res(TINFO, "ac_btime < %d (%d)", start_time,
>                         ACCT_MEMBER(ac_btime));
>                 ret = 1;

Ack.

> > > race-y in environments with higher steal time:


> > I'm sorry, what does it mean here?

> I was referring to failed check below. s390 is scarce resource
> and when over-committed, sleeps are less consistent.
> E.g. sleep(1) taking 2+ seconds:
>   nanosleep({1, 0}, NULL) = 0 <1.926617>

Lol :)

Kind regards,
Petr


More information about the ltp mailing list