[LTP] [PATCH v2] tst_dev_bytes_written: parsing /proc/diskstats instead of sys file

Cyril Hrubis chrubis@suse.cz
Fri Jan 10 13:30:12 CET 2020


Hi!
> > Maybe, I am fine with your way(I tested it). I only  refer to kernel
> > documention [1] .sysfs and proc file  use the same source for the
> > information and so should not differ. So I use fixed format as kernel
> > function to exact.  Also, I want to listen advise from Sumit.
> >
> 
> TBH, I think it's just a matter of taste. I am fine with either approach.

I dot not like that much that we generate the scanf format string on the
fly in the version that parses /proc/diskstat.

In the end we have to merge one of them, I slightly prefer mine, but I
do not have a strong feelings about this.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list