[LTP] [PATCH v2] tst_dev_bytes_written: parsing /proc/diskstats instead of sys file
Petr Vorel
pvorel@suse.cz
Wed Jan 15 11:46:27 CET 2020
Hi,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > > Maybe, I am fine with your way(I tested it). I only refer to kernel
> > > documention [1] .sysfs and proc file use the same source for the
> > > information and so should not differ. So I use fixed format as kernel
> > > function to exact. Also, I want to listen advise from Sumit.
> > TBH, I think it's just a matter of taste. I am fine with either approach.
> I dot not like that much that we generate the scanf format string on the
> fly in the version that parses /proc/diskstat.
+1
> In the end we have to merge one of them, I slightly prefer mine, but I
> do not have a strong feelings about this.
+1
If we merge Cyril's, I'd be for adding the hint about LTP_DEV (maybe as a
separate commit).
Thank you both for working on this fix.
Kind regards,
Petr
More information about the ltp
mailing list