[LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib

Yang Xu xuyang2018.jy@cn.fujitsu.com
Wed Jun 10 10:21:22 CEST 2020


Hi Petr

> Hi Xu,
> 
>> Hi Petr
> 
>> Nothing blocks this simple patch, I guess we can directly push this
>> patch(don't forget jan's acked-by).
> 
> I guess you missed librealtime.a in (testcases/realtime/lib/Makefile).
Yes.
> 
> Maybe removing libdir could be in separate commit, it looks to me as unrelated
> change.
> 
Agree.
> And you haven't replied to my question:
> https://lists.linux.it/pipermail/ltp/2020-June/017495.html
> 
> But newer mind :). Maybe it's just me, but "Also include Android_libpthread and
> android_librt." is not clear to me. I'd phrase it: "Also change Android_libpthread and
> android_librt" (because include is ambiguous, when we're trying not to
> install/include these statically linked libraries.
Yes, My meaning is that v1 does not modify 
Android_libpthread/android_librt, and v2 does this. Using modify is better.

> 
> BTW if you ack it, I can do this changes before merge.
acked.

Best Regards
Yang Xu
> 
> Kind regards,
> Petr
> 
> 




More information about the ltp mailing list