[LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib
Petr Vorel
pvorel@suse.cz
Wed Jun 10 11:51:25 CEST 2020
Hi Xu,
> > I guess you missed librealtime.a in (testcases/realtime/lib/Makefile).
> Yes.
> > Maybe removing libdir could be in separate commit, it looks to me as unrelated
> > change.
Actually, when looking into this more (this part is new in v2, Jan didn't review
it).
I'd keep keep libdir in include/mk/config.mk.in, because we use it in our
lib/ltp.pc file. Maybe we don't need if we don't install any library, but then
we should remove also LIB variable and associated code in include/mk/lib.mk.
Which should be a second step (second commit).
Also libdir is somehow expected by automake (it's referenced in generated
./m4/Makefile.in ./testcases/realtime/m4/Makefile.in).
Kind regards,
Petr
More information about the ltp
mailing list