[LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib
Xiao Yang
yangx.jy@cn.fujitsu.com
Wed Jun 10 10:47:13 CEST 2020
On 2020/6/10 16:05, Petr Vorel wrote:
> Hi Xu,
>
>> Hi Petr
>
>> Nothing blocks this simple patch, I guess we can directly push this
>> patch(don't forget jan's acked-by).
>
> I guess you missed librealtime.a in (testcases/realtime/lib/Makefile).
>
> Maybe removing libdir could be in separate commit, it looks to me as unrelated
> change.
Hi Petr, Xu
Agreed, This patch should focus on replacing LIB with INTERNAL_LIB.
My question about the issue is not important, we can just keep libdir
for now as you want because someone may add dynamic library linking in
future.
Thanks,
Xiao Yang
>
> And you haven't replied to my question:
> https://lists.linux.it/pipermail/ltp/2020-June/017495.html
>
> But newer mind :). Maybe it's just me, but "Also include Android_libpthread and
> android_librt." is not clear to me. I'd phrase it: "Also change Android_libpthread and
> android_librt" (because include is ambiguous, when we're trying not to
> install/include these statically linked libraries.
>
> BTW if you ack it, I can do this changes before merge.
>
> Kind regards,
> Petr
>
More information about the ltp
mailing list