[LTP] [PATCH 1/4] syscalls/sync01: Remove it

Yang Xu xuyang2018.jy@cn.fujitsu.com
Sat Nov 7 01:53:25 CET 2020


Hi Xiao, Cyril
> On 11/7/20 12:47 AM, Cyril Hrubis wrote:
>> Hi!
>>> I have a doubt after reading Xu's patch[1] and Martin's patch[2]:
>>>
>>> 1) Xu removed sync01 because sync() always return 0.
>> Actually sync() is defined as void function, so the tests were bogusly
>> checking the TST_RET value which haven't been set at all.
>
> Hi Cyril,
>
> Oops, I gave a wrong example. :-(
>
> On error, I just wonder if we need to check all return value(i.e.
> negative value except -1).
>
> IOW, Is it possible for syscall to get a error value which is not -1?
IMO, get a error and syscall return -1 that is a normal situation. 
Martin creates a standard model for it and doesn't match this rule is 
wrong, so we can check syscall whether return the right value when 
kernel changes these api in the future.

Best Regards,
Yang Xu
>
> Best Regards,
>
> Xiao Yang
>
>>
>
>





More information about the ltp mailing list