[LTP] [PATCH 1/2] fanotify: Move safe_fanotify_init() + safe macro into fanotify.h

Petr Vorel pvorel@suse.cz
Wed Oct 14 20:02:21 CEST 2020


Hi,

> > Fanotify code is used only in testcases/kernel/syscalls/fanotify/, which
> > justify breaking rule of having safe function and macro outside of
> > library. This will be further cleaned in next commit.

> I guess that this is OK, I doubt that we will need a fanotify_init()
> anywhere else but the fanotify testcases.
Amir acked whole patch some time ago, thus I guess he's not against this first one.

The original motivation was to do further modifications for libc wrapper vs.
syscall() for fanotify_init() and fanotify_mark(). But I guess even without
second commit it makes sense to have all fanotify helpers together.
We can always revert it if really need them as safe macros.

Kind regards,
Petr


More information about the ltp mailing list