[LTP] [PATCH 1/2] fanotify: Move safe_fanotify_init() + safe macro into fanotify.h

[Li Wang]

On Thu, Oct 15, 2020 at 2:02 AM Petr Vorel <pvorel@suse.cz> wrote:

> Hi,
>
> > > Fanotify code is used only in testcases/kernel/syscalls/fanotify/,
> which
> > > justify breaking rule of having safe function and macro outside of
> > > library. This will be further cleaned in next commit.
>
> > I guess that this is OK, I doubt that we will need a fanotify_init()
> > anywhere else but the fanotify testcases.
> Amir acked whole patch some time ago, thus I guess he's not against this
> first one.
>
> The original motivation was to do further modifications for libc wrapper
> vs.
> syscall() for fanotify_init() and fanotify_mark(). But I guess even without
> second commit it makes sense to have all fanotify helpers together.
> We can always revert it if really need them as safe macros.
>
+1

Reviewed-by: Li Wang <liwang@redhat.com>

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20201016/9eb28f53/attachment-0001.htm>