[LTP] [PATCH v2] Refactoring dio_sparse.c using LTP API
Andrea Cervesato
andrea.cervesato@suse.com
Tue Dec 7 17:45:44 CET 2021
Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
testcases/kernel/io/ltp-aiodio/common.h | 64 ++++++
testcases/kernel/io/ltp-aiodio/dio_sparse.c | 235 +++++++-------------
2 files changed, 139 insertions(+), 160 deletions(-)
diff --git a/testcases/kernel/io/ltp-aiodio/common.h b/testcases/kernel/io/ltp-aiodio/common.h
index fefeed2cf..c065edb55 100644
--- a/testcases/kernel/io/ltp-aiodio/common.h
+++ b/testcases/kernel/io/ltp-aiodio/common.h
@@ -51,4 +51,68 @@ static inline void io_append(const char *path, char pattern, int flags, size_t b
SAFE_CLOSE(fd);
}
+static inline void io_read(const char *filename, int filesize, int **run_child)
+{
+ char buff[4096];
+ int fd;
+ int i;
+ int r;
+
+ while ((fd = open(filename, O_RDONLY, 0666)) < 0)
+ usleep(100);
+
+ tst_res(TINFO, "child %i reading file", getpid());
+
+ while (**run_child) {
+ off_t offset = 0;
+ char *bufoff;
+
+ SAFE_LSEEK(fd, SEEK_SET, 0);
+
+ for (i = 0; i < filesize + 1; i += sizeof(buff)) {
+ r = SAFE_READ(0, fd, buff, sizeof(buff));
+ if (r > 0) {
+ bufoff = check_zero(buff, r);
+ if (bufoff) {
+ tst_res(TINFO, "non-zero read at offset %zu",
+ offset + (bufoff - buff));
+ break;
+ }
+ offset += r;
+ }
+ }
+ }
+
+ SAFE_CLOSE(fd);
+}
+
+/*
+ * This code tries to create dirty free blocks on
+ * the HDD so there is a chance that blocks to be allocated
+ * for a file are filled with something else than zeroes.
+ *
+ * The usefulness of this is IMHO questionable.
+ */
+static inline void dirty_freeblocks(int size)
+{
+ char *filename = "dirty_file";
+ int fd;
+ void *p;
+ int pg;
+
+ pg = getpagesize();
+ size = ((size + pg - 1) / pg) * pg;
+
+ fd = SAFE_OPEN(filename, O_CREAT | O_RDWR, 0600);
+ SAFE_FTRUNCATE(fd, size);
+
+ p = SAFE_MMAP(NULL, size, PROT_WRITE | PROT_READ, MAP_SHARED | MAP_FILE, fd, 0);
+ memset(p, 0xaa, size);
+ msync(p, size, MS_SYNC);
+ munmap(p, size);
+
+ SAFE_CLOSE(fd);
+ SAFE_UNLINK(filename);
+}
+
#endif /* AIODIO_COMMON_H__ */
diff --git a/testcases/kernel/io/ltp-aiodio/dio_sparse.c b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
index 3f44e92ea..0b3b26e0d 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_sparse.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (c) 2004 Daniel McNeil <daniel@osdl.org>
* 2004 Open Source Development Lab
@@ -6,206 +7,120 @@
*
* Copyright (c) 2011 Cyril Hrubis <chrubis@suse.cz>
*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
- * the GNU General Public License for more details.
+ * Copyright (C) 2021 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
+ */
+
+/*\
+ * [Description]
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ * Create a sparse file using O_DIRECT while other processes are doing
+ * buffered reads and check if the buffer reads always see zero.
*/
#define _GNU_SOURCE
#include <stdlib.h>
-#include <sys/types.h>
-#include <signal.h>
-#include <errno.h>
-#include <fcntl.h>
-#include <stdio.h>
#include <unistd.h>
-#include <memory.h>
-#include <sys/mman.h>
+#include <string.h>
#include <sys/wait.h>
-#include <limits.h>
-#include <getopt.h>
-
-#include "test.h"
-#include "safe_macros.h"
+#include "tst_test.h"
+#include "common.h"
-#define NUM_CHILDREN 1000
+static int *run_child;
-static void setup(void);
-static void cleanup(void);
-static void usage(void);
-static int debug = 0;
-static int fd;
+static char *str_numchildren;
+static char *str_writesize;
+static char *str_filesize;
+static char *str_offset;
-char *TCID = "dio_sparse";
-int TST_TOTAL = 1;
+static struct tst_option options[] = {
+ {"n:", &str_numchildren, "Number of threads (default 1000)"},
+ {"w:", &str_writesize, "Size of writing blocks (default 1024)"},
+ {"s:", &str_filesize, "Size of file (default 100M)"},
+ {"o:", &str_offset, "File offset (default 0)"},
+ {NULL, NULL, NULL}
+};
-#include "common_sparse.h"
-
-/*
- * Write zeroes using O_DIRECT into sparse file.
- */
-int dio_sparse(int fd, int align, int writesize, int filesize, int offset)
+static void dio_sparse(int fd, int filesize, int writesize)
{
void *bufptr = NULL;
- int i, w;
+ int i;
+ int w;
- TEST(posix_memalign(&bufptr, align, writesize));
- if (TEST_RETURN) {
- tst_resm(TBROK | TRERRNO, "cannot allocate aligned memory");
- return 1;
- }
+ bufptr = SAFE_MEMALIGN(getpagesize(), writesize);
memset(bufptr, 0, writesize);
- lseek(fd, offset, SEEK_SET);
- for (i = offset; i < filesize;) {
- if ((w = write(fd, bufptr, writesize)) != writesize) {
- tst_resm(TBROK | TERRNO, "write() returned %d", w);
- return 1;
- }
+ SAFE_LSEEK(fd, 0, SEEK_SET);
+ for (i = 0; i < filesize;) {
+ w = SAFE_WRITE(0, fd, bufptr, writesize);
i += w;
}
+}
- return 0;
+static void setup(void)
+{
+ run_child = SAFE_MMAP(NULL, sizeof(int), PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANONYMOUS, -1, 0);
+
+ tst_res(TINFO, "Dirtying free blocks");
+ dirty_freeblocks(100 * 1024 * 1024);
}
-void usage(void)
+static void cleanup(void)
{
- fprintf(stderr, "usage: dio_sparse [-d] [-n children] [-s filesize]"
- " [-w writesize] [-o offset]]\n");
- exit(1);
+ SAFE_MUNMAP(run_child, sizeof(int));
}
-int main(int argc, char **argv)
+static void run(void)
{
char *filename = "dio_sparse";
- int pid[NUM_CHILDREN];
- int num_children = 1;
- int i;
- long alignment = 512;
- int writesize = 65536;
+ int numchildren = 1000;
+ int writesize = 1024;
int filesize = 100 * 1024 * 1024;
int offset = 0;
- int c;
- int children_errors = 0;
- int ret;
-
- while ((c = getopt(argc, argv, "dw:n:a:s:o:")) != -1) {
- char *endp;
- switch (c) {
- case 'd':
- debug++;
- break;
- case 'a':
- alignment = strtol(optarg, &endp, 0);
- alignment = scale_by_kmg(alignment, *endp);
- break;
- case 'w':
- writesize = strtol(optarg, &endp, 0);
- writesize = scale_by_kmg(writesize, *endp);
- break;
- case 's':
- filesize = strtol(optarg, &endp, 0);
- filesize = scale_by_kmg(filesize, *endp);
- break;
- case 'o':
- offset = strtol(optarg, &endp, 0);
- offset = scale_by_kmg(offset, *endp);
- break;
- case 'n':
- num_children = atoi(optarg);
- if (num_children > NUM_CHILDREN) {
- fprintf(stderr,
- "number of children limited to %d\n",
- NUM_CHILDREN);
- num_children = NUM_CHILDREN;
- }
- break;
- case '?':
- usage();
- break;
- }
- }
+ int status;
+ int fd;
+ int i;
- setup();
- tst_resm(TINFO, "Dirtying free blocks");
- dirty_freeblocks(filesize);
-
- fd = SAFE_OPEN(cleanup, filename,
- O_DIRECT | O_WRONLY | O_CREAT | O_EXCL, 0600);
- SAFE_FTRUNCATE(cleanup, fd, filesize);
-
- tst_resm(TINFO, "Starting I/O tests");
- signal(SIGTERM, SIG_DFL);
- for (i = 0; i < num_children; i++) {
- switch (pid[i] = fork()) {
- case 0:
- SAFE_CLOSE(NULL, fd);
- read_sparse(filename, filesize);
- break;
- case -1:
- while (i-- > 0)
- kill(pid[i], SIGTERM);
-
- tst_brkm(TBROK | TERRNO, cleanup, "fork()");
- default:
- continue;
- }
- }
- tst_sig(FORK, DEF_HANDLER, cleanup);
+ if (tst_parse_int(str_numchildren, &numchildren, 1, INT_MAX))
+ tst_brk(TBROK, "Invalid number of children '%s'", str_numchildren);
- ret = dio_sparse(fd, alignment, writesize, filesize, offset);
+ if (tst_parse_int(str_writesize, &writesize, 1, INT_MAX))
+ tst_brk(TBROK, "Invalid write blocks size '%s'", str_writesize);
- tst_resm(TINFO, "Killing childrens(s)");
+ if (tst_parse_filesize(str_filesize, &filesize, 1, LONG_LONG_MAX))
+ tst_brk(TBROK, "Invalid file size '%s'", str_filesize);
- for (i = 0; i < num_children; i++)
- kill(pid[i], SIGTERM);
+ if (tst_parse_int(str_offset, &offset, 0, INT_MAX))
+ tst_brk(TBROK, "Invalid file offset '%s'", str_offset);
- for (i = 0; i < num_children; i++) {
- int status;
- pid_t p;
+ fd = SAFE_OPEN(filename, O_DIRECT | O_WRONLY | O_CREAT, 0666);
+ SAFE_FTRUNCATE(fd, filesize);
- p = waitpid(pid[i], &status, 0);
- if (p < 0) {
- tst_resm(TBROK | TERRNO, "waitpid()");
- } else {
- if (WIFEXITED(status) && WEXITSTATUS(status) == 10)
- children_errors++;
+ *run_child = 1;
+
+ for (i = 0; i < numchildren; i++) {
+ if (!SAFE_FORK()) {
+ io_read(filename, filesize, &run_child);
+ return;
}
}
- if (children_errors)
- tst_resm(TFAIL, "%i children(s) exited abnormally",
- children_errors);
+ dio_sparse(fd, filesize, writesize);
- if (!children_errors && !ret)
- tst_resm(TPASS, "Test passed");
+ if (SAFE_WAITPID(-1, &status, WNOHANG))
+ tst_res(TFAIL, "Non zero bytes read");
+ else
+ tst_res(TPASS, "All bytes read were zeroed");
- cleanup();
- tst_exit();
+ *run_child = 0;
}
-static void setup(void)
-{
- tst_sig(FORK, DEF_HANDLER, cleanup);
- tst_tmpdir();
-}
-
-static void cleanup(void)
-{
- if (fd > 0 && close(fd))
- tst_resm(TWARN | TERRNO, "Failed to close file");
-
- tst_rmdir();
-}
+static struct tst_test test = {
+ .test_all = run,
+ .setup = setup,
+ .cleanup = cleanup,
+ .options = options,
+ .needs_tmpdir = 1,
+ .forks_child = 1,
+};
--
2.34.1
More information about the ltp
mailing list