[LTP] [PATCH 1/1] lib: Add support for debugging .all_filesystems

Cyril Hrubis chrubis@suse.cz
Tue Dec 14 11:35:39 CET 2021


Hi!
> > My only concern is that the variable name is too long and not easy
> > to remember/understand usage. Can we find a better name?
> >     LTP_ONE_FS_TYPE
> >     LTP_ASGD_FD_TYPE
> >     LTP_FS_TYPE_DEBUG
> Yes, it's too long. LTP_FS_TYPE_DEBUG sounds best to me, but no strong opinion
> about it.

Not sure about the "DEBUG" in the name. I would go for a variation of
the first name "LTP_SINGLE_FS_TYPE" or "LTP_LIMIT_FS_TYPE"

> If we agree we want this, we can consider to use some switch instead or print
> this variable in help output (-h), with other variables from
> https://github.com/linux-test-project/ltp/wiki/User-Guidelines.

Printing the variables on -h does sounds reasonabe.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list