[LTP] [PATCH 1/1] lib: Add support for debugging .all_filesystems

Petr Vorel pvorel@suse.cz
Tue Dec 14 12:27:06 CET 2021


Hi all,

> Hi!
> > > My only concern is that the variable name is too long and not easy
> > > to remember/understand usage. Can we find a better name?
> > >     LTP_ONE_FS_TYPE
> > >     LTP_ASGD_FD_TYPE
> > >     LTP_FS_TYPE_DEBUG
> > Yes, it's too long. LTP_FS_TYPE_DEBUG sounds best to me, but no strong opinion
> > about it.

> Not sure about the "DEBUG" in the name. I would go for a variation of
> the first name "LTP_SINGLE_FS_TYPE" or "LTP_LIMIT_FS_TYPE"
LTP_SINGLE_FS_TYPE looks better for me, because I'd understand LIMIT to run
fewer filesystems but possibly more than one.

> > If we agree we want this, we can consider to use some switch instead or print
> > this variable in help output (-h), with other variables from
> > https://github.com/linux-test-project/ltp/wiki/User-Guidelines.

> Printing the variables on -h does sounds reasonabe.
+1 (post v2).

Kind regards,
Petr


More information about the ltp mailing list