[LTP] [PATCH] syscalls/ioctl_loop05.c: skip test on overlay filesystem

Cyril Hrubis chrubis@suse.cz
Tue Jan 5 16:24:39 CET 2021


Hi!
> diff --git a/lib/tst_device.c b/lib/tst_device.c
> index c096b418b..de64fd908 100644
> --- a/lib/tst_device.c
> +++ b/lib/tst_device.c
> @@ -534,6 +534,10 @@ void tst_find_backing_dev(const char *path, char *dev)
>          if (stat(dev, &buf) < 0)
>                  tst_brkm(TWARN | TERRNO, NULL, "stat(%s) failed", dev);
> 
> -       if (S_ISBLK(buf.st_mode) != 1)
> -               tst_brkm(TCONF, NULL, "dev(%s) isn't a block dev", dev);
> +       if (S_ISBLK(buf.st_mode) != 1) {
> +               if (tst_is_mounted(dev))
> +                       tst_find_backing_dev(dev, dev);
> +               else
> +                       tst_brkm(TCONF, NULL, "dev(%s) isn't a block 
> dev", dev);
> +       }
>   }
> 
> My test environment is that
> /dev/sda10              20G  623M   18G   4% /mnt/xfstests/test
> /mnt/xfstests/test      20G  623M   18G   4% /mnt/xfstests/test/ovl-mnt
> /dev/sda11              20G   46M   19G   1% /mnt/xfstests/scratch
> /mnt/xfstests/scratch   20G   46M   19G   1% /mnt/xfstests/scratch/ovl-mnt
> 
> and my TMPDIR env is /mnt/xfstests/test/ovl-mnt.

Does this code works for everyone or should we apply patch that disables
the test on overlay so that it's fixed for next release?

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list