[LTP] [PATCH 5/5] syscalls/move_pages12: Add one more kernel git hash

Petr Vorel pvorel@suse.cz
Tue Jan 5 19:16:46 CET 2021


Hi Cyril,

> Hi!
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> Patchset pushed, thanks for the review.
Great, thanks!

> > ...
> > > -/*
> > > - * Description:
> > > +/*\
> > > + * [DESCRIPTION]
> > > + *
> > > + * *Test 1*
> > >   *
> > > - * Test #1:
> > > - *  This is a regression test for the race condition between move_pages()
> > > - *  and freeing hugepages, where move_pages() calls follow_page(FOLL_GET)
> > > - *  for hugepages internally and tries to get its refcount without
> > > - *  preventing concurrent freeing.
> > > + * This is a regression test for the race condition between move_pages()
> > > + * and freeing hugepages, where move_pages() calls follow_page(FOLL_GET)
> > > + * for hugepages internally and tries to get its refcount without
> > > + * preventing concurrent freeing.
> > >   *
> > > - *  This test can crash the buggy kernel, and the bug was fixed in:
> > > + * This test can crash the buggy kernel, and the bug was fixed in:
> > >   *
> > >   *   commit e66f17ff71772b209eed39de35aaa99ba819c93d
> > >   *   Author: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> > I wonder if we should format "commit XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" as
> > link to Linus' tree (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX).

> Well we do have links in the tags anyways so I think that it's a bit
> more readable as it is.

I meant in the output (pdf, html) the text would be the same but become link to
Linus' tree (instead of being a plain text).

But that's really minor.

Kind regards,
Petr


More information about the ltp mailing list