[LTP] [PATCH] mbind01: accept MPOL_LOCAL when passing empty set for MPOL_PREFERRED

Li Wang liwang@redhat.com
Thu Jul 29 10:52:29 CEST 2021


On Thu, Jul 29, 2021 at 4:33 PM Jan Stancek <jstancek@redhat.com> wrote:

>
>
> On Thu, Jul 29, 2021 at 9:27 AM Li Wang <liwang@redhat.com> wrote:
>
>>
>>
>> On Mon, Jul 26, 2021 at 8:53 PM Jan Stancek <jstancek@redhat.com> wrote:
>>
>>> When empty set is passed to MPOL_PREFERRED, memory is allocated
>>> on the node of the CPU that triggered the allocation.
>>>
>>> After kernel commit:
>>>   7858d7bca7fb ("mm/mempolicy: don't handle MPOL_LOCAL like a fake
>>> MPOL_PREFERRED policy")
>>> kernel returns stored policy as MPOL_LOCAL.
>>>
>>
>> As the MPOL_LOCAL has been setup as a real policy, I'm wondering should we
>> add more tests for it in the next? e.g.
>>
>
> Right, but we also need something in setup to avoid running it
> for kernels that don't support MPOL_LOCAL.
>

+1 we can achieve that in a separate patch.

I'm also planning to add one more function which named mbind_policy_name()
in the mbind.h to help make the log more readable, just like what we did in:
   static inline const char *mbind_flag_name(unsigned flag)

And yes, we can do that separately.


> You're right that parameters in tst_res message appear to be in wrong
> order.
>

Feel free to fix it while merging this patch.

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210729/0dbee0c1/attachment.htm>


More information about the ltp mailing list