[LTP] [RFC PATCH] fallocate05: increase the fallocate and defallocate size

Cyril Hrubis chrubis@suse.cz
Wed Sep 22 11:56:59 CEST 2021


Hi!
> > Looking at the test I do not think there is a reason to allocate more
> > than a two or four blocks for the buffer. We just need to write() to the
> > fallocated area in a loop one block at a time until it's full. I do not
> > think that it's a good idea to pass ~100MB buffer to a single write()
> > and expect it to succeed anyways.
> >
> 
> Sounds practical.
> 
> Btw, If we don't create such a larger buffer area, then we have to
> count the loop times must as equal to bufsize/blocksize. Otherwise,
> we can't guarantee the test behavior is correct.

Strangely enough we allready do exactly that for the second part of the test.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list