[LTP] [RFC PATCH] fallocate05: increase the fallocate and defallocate size

Li Wang liwang@redhat.com
Wed Sep 22 12:34:21 CEST 2021


On Wed, Sep 22, 2021 at 5:56 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > > Looking at the test I do not think there is a reason to allocate more
> > > than a two or four blocks for the buffer. We just need to write() to
> the
> > > fallocated area in a loop one block at a time until it's full. I do not
> > > think that it's a good idea to pass ~100MB buffer to a single write()
> > > and expect it to succeed anyways.
> > >
> >
> > Sounds practical.
> >
> > Btw, If we don't create such a larger buffer area, then we have to
> > count the loop times must as equal to bufsize/blocksize. Otherwise,
> > we can't guarantee the test behavior is correct.
>
> Strangely enough we allready do exactly that for the second part of the
> test.
>

That try one by one block after filling full of the FS because nobody knows
when fails.

But as you suggested we can do that as well for the previous allocation :).

So, will you create a patch, or I do that tomorrow?

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210922/60abe39b/attachment.htm>


More information about the ltp mailing list