[LTP] [PATCH v4] Rewrite userns06.c using new LTP API

[Andrea Cervesato]

Hi Petr,

sure you can merge. Thanks!

Andrea

On 4/19/22 09:22, Petr Vorel wrote:
> Hi Andrea,
>
> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>
> 2 small things:
>
> Actually adding one more #ifdef HAVE_LIBCAP
> might be better than calling tst_brk() manually (this is better than my previous
> suggestion):
>
> #include "config.h"
>
> #ifdef HAVE_LIBCAP
> # define TST_NO_DEFAULT_MAIN
> #endif
>
> #include "tst_test.h"
>
> #ifdef HAVE_LIBCAP
>
> #include <string.h>
> #include <sys/wait.h>
> #include <sys/capability.h>
>
> int main(int argc, char *argv[])
> {
> ...
> }
>
> #else
> TST_TEST_TCONF("System is missing libcap");
> #endif
>
> But if you prefer to original version (define main), then TCONF should be used.
>
> Also #define _GNU_SOURCE is not needed, it should be dropped.
>
> If you agree, I can merge it with proposed changes.
>
> Kind regards,
> Petr
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220419/9d759d0a/attachment.htm>