[LTP] [PATCH v2 2/3] KVM test infrastructure

[Martin Doucha]

On 20. 04. 22 11:11, Cyril Hrubis wrote:
>> I didn't #include the tst_res_flags.h because the main LTP include
>> directory is not passed to the preprocessor when compiling KVM payload.
>> I'd have to do it like this:
>> #include "../../../../include/tst_res_flags.h"
> 
> And I guess that this is on purpose right?
> 
> As we can easily add it by adding -I$(top_src_dir)/include/ to the
> CFLAGS.

Yes, this is on purpose. I want any #include of standard LTP headers to
trigger error because the vast majority of the functions declared in
there are not available in KVM guest library. So should I add the dirty
#include or should I keep the duplicate definition of tst_res flags?

>> I guess that copying LTP_ALIGN() to the KVM headers would be useful.
> 
> Can you please respin the patchset with this change then?

Yes, as soon as we agree on the #includes above.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic