[LTP] [PATCH v2 2/3] KVM test infrastructure

Cyril Hrubis chrubis@suse.cz
Wed Apr 20 11:52:23 CEST 2022


Hi!
> >> I didn't #include the tst_res_flags.h because the main LTP include
> >> directory is not passed to the preprocessor when compiling KVM payload.
> >> I'd have to do it like this:
> >> #include "../../../../include/tst_res_flags.h"
> > 
> > And I guess that this is on purpose right?
> > 
> > As we can easily add it by adding -I$(top_src_dir)/include/ to the
> > CFLAGS.
> 
> Yes, this is on purpose. I want any #include of standard LTP headers to
> trigger error because the vast majority of the functions declared in
> there are not available in KVM guest library. So should I add the dirty
> #include or should I keep the duplicate definition of tst_res flags?

I wonder what is cleaner solution. I do not like either one that much to
be honest, but I guess that I slightly prefer the ugly relative path
over copying the definitions over.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list