[LTP] [PATCH 1/1] aio-stress.c: Use static variable iterations

Petr Vorel pvorel@suse.cz
Mon Dec 12 17:03:22 CET 2022


local iteration variable in worker() was probably left over from
previous versions rewrite (maybe -i was not used in previous versions).

Clang correctly reported:
aio-stress.c:1049:6: warning: variable 'iteration' set but not used [-Wunused-but-set-variable]
int iteration = 0;

Fixes: 054d45390 ("Rewrite aio-stress test using LTP API")

Reported-by: Richard Palethorpe <rpalethorpe@suse.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,

reported by Richie [1], I got confused thus merge before this fix.

[1] https://lore.kernel.org/ltp/87h6yfifbr.fsf@suse.de/

 testcases/kernel/io/ltp-aiodio/aio-stress.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/testcases/kernel/io/ltp-aiodio/aio-stress.c b/testcases/kernel/io/ltp-aiodio/aio-stress.c
index 39db14d65..29e679087 100644
--- a/testcases/kernel/io/ltp-aiodio/aio-stress.c
+++ b/testcases/kernel/io/ltp-aiodio/aio-stress.c
@@ -1046,7 +1046,6 @@ static int *worker(struct thread_info *t)
 	char *this_stage = NULL;
 	struct timeval stage_time;
 	int status = 0;
-	int iteration = 0;
 	int cnt;
 
 	aio_setup(&t->io_ctx, 512);
@@ -1151,7 +1150,7 @@ restart:
 
 	/* someone got restarted, go back to the beginning */
 	if (t->active_opers && cnt < iterations) {
-		iteration++;
+		iterations++;
 		goto restart;
 	}
 
-- 
2.38.1



More information about the ltp mailing list