[LTP] [RFC??[DO_NOT_MERGE][PATCH v2 1/1] netstress: Fix race between SETSID() and exit(0)

[Cyril Hrubis]

Hi!
> >         tst_res_ TINFO "run server 'netstress $s_opts'"
> >         tst_res_ TINFO "run client 'netstress -l $c_opts' $run_cnt times"
> 
> 
> Yes, this looks like enough. Do you want me to merge this proposal with added
> this change? Or you send a patch or just merge fix yourself?

Just merge it all into a single patch.

> > However the debugging took longer than I wanted to since the network
> > tests are such a mess. The server does exit by TBROK (which looks like
> > it's an expected behavior), only half of the sever log is printed on a
> > failure, etc. These should really deserve some cleanups...
> I'd say specifically tst_netload() (in tst_net.sh) and netstress.c deserve
> cleanup. Also, as we noticed several times shell tests tends to be buggy,
> specially in combination with C tests. But not sure if feasible to write
> everything in C.

I guess that we can do some minor fixes, but the whole codebase looks
like it needs to be rethinked and redesigned...

-- 
Cyril Hrubis
chrubis@suse.cz