[LTP] [RFC??[DO_NOT_MERGE][PATCH v2 1/1] netstress: Fix race between SETSID() and exit(0)

Petr Vorel pvorel@suse.cz
Mon Feb 21 14:36:19 CET 2022


Hi Cyril,

merged, thanks!

> > Yes, this looks like enough. Do you want me to merge this proposal with added
> > this change? Or you send a patch or just merge fix yourself?

> Just merge it all into a single patch.
Sure this was to go to single commit, just wasn't sure if you want to merge it.

> > > However the debugging took longer than I wanted to since the network
> > > tests are such a mess. The server does exit by TBROK (which looks like
> > > it's an expected behavior), only half of the sever log is printed on a
> > > failure, etc. These should really deserve some cleanups...
> > I'd say specifically tst_netload() (in tst_net.sh) and netstress.c deserve
> > cleanup. Also, as we noticed several times shell tests tends to be buggy,
> > specially in combination with C tests. But not sure if feasible to write
> > everything in C.

> I guess that we can do some minor fixes, but the whole codebase looks
> like it needs to be rethinked and redesigned...
+1

Kind regards,
Petr


More information about the ltp mailing list