[LTP] [PATCH v4 5/6] syscalls/quotactl09: Test error when quota info hidden in filesystem

Cyril Hrubis chrubis@suse.cz
Tue Jan 11 11:55:54 CET 2022


Hi!
> >So we pass a fd that
> > points to a device and we expect ENOTBLK if tst_variant == 1 and
> > exp_err == ENOTBLK? That does not sound fine, what do I miss?
> We skip ENOTBLK error test when tst_variant ==1
> 
>    	if (tst_variant) {
>    		if (tc->exp_err == ENOTBLK) {
>    			tst_res(TCONF, "quotactl_fd() doesn't have this error, skip");
>    			return;
>    		}
>    	}

Ah, that's what I have missed. But still, what happen if we pass fd to a
regular file to the quotactl_fd()? Shouldn't we test that case too?

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list