[LTP] [PATCH v4 5/6] syscalls/quotactl09: Test error when quota info hidden in filesystem

[xuyang2018.jy@fujitsu.com]

Hi Cyril
> Hi!
>>> So we pass a fd that
>>> points to a device and we expect ENOTBLK if tst_variant == 1 and
>>> exp_err == ENOTBLK? That does not sound fine, what do I miss?
>> We skip ENOTBLK error test when tst_variant ==1
>>
>>     	if (tst_variant) {
>>     		if (tc->exp_err == ENOTBLK) {
>>     			tst_res(TCONF, "quotactl_fd() doesn't have this error, skip");
>>     			return;
>>     		}
>>     	}
>
> Ah, that's what I have missed. But still, what happen if we pass fd to a
> regular file to the quotactl_fd()? Shouldn't we test that case too?
Good suggestion.
Yes, AFAIK, the fd point to superblock, every subcmd will check quota 
feature bit or whether enable but return different errno.

I will test Q_QUOTAON with regular file fd because it is the most 
meaningful.

Best Regards
Yang Xu
>