[LTP] [PATCH v1] Replace ltp_syscall with tst_syscall

[Andrea Cervesato]

Hi Petr!

 From my point of view, it would be nice if lapi code would only contain 
fallback code, without LTP API that requires tst_test.h or test.h. So it 
would be easy to split fallback code from "utilities" headers containing 
the most common functionalities to break the test if fallback functions 
are failing. This is the case of lapi/syscalls.h where tst_syscall is 
defined, but IMHO it should be defined out, somewhere in a "utils" 
header imported by tst_test.h or by tests which requires specific 
functionalities.

This is possible only if all the tests are already in the new LTP API 
version tho, since old tests require to be refactored first.

Kind regards,

Andrea

On 1/20/22 13:16, Petr Vorel wrote:
> Hi Andrea,
>
>> This modification is a first step into the old LTP API replacement and
>> it has been completed with the following procedure:
>> - removed ltp_syscall
>> - replaced ltp_syscall with tst_syscall inside all tests
>> - reshuffled headers inside tests to import tst_test.h before
>>    lapi/syscalls.h
> So far we've done cleanup as whole test one by one.
> Sure, why not solving one issue once.
>
> Generally LGTM. I'd just appreciate if tst_test.h didn't have to be loaded at
> first, but that's a minor issue.
>
> also with these whole tree patches it's a problem that it either breaks some of
> other patches (they will not be applicable) or this patch will not be applicable
> (if not applied soon after the release).
>
> Kind regards,
> Petr
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220120/78acd343/attachment-0001.htm>