[LTP] [PATCH 1/2] KVM test infrastructure

[Li Wang]

Hi Martin,

Martin Doucha <mdoucha@suse.cz> wrote:


> >> +    /* Create VM */
> >
> > These comments are pretty redundant when we have ioctl's like
> > KVM_CREATE_VM and KVM_CREATE_VCPU. There are much harder things to
> > understand in this patchset.
>
> I know that the code is straightforward. But it's quite dense so I've
> added the comments as section headers for easier navigation when you
> need to change something.
>

I have no dissent on the comments.

But I'm wondering do we need a check if the SUT support
creating VM before doing that? Or, should we guarantee
the KVM module is enabled.

I simply built these codes and got TBROK on my KVM guest.
Probably we should avoid this but I hoping it can skip gracefully.

[root@local-guest-rhel83 ~]# virt-what
kvm

# ./kvm_pagefault01
tst_sys_conf.c:64: TINFO: Path not found:
'/sys/module/kvm/parameters/tdp_mmu'
tst_test.c:1458: TINFO: Timeout per run is 0h 05m 00s
lib_host.c:133: TBROK: open(/dev/kvm,2,0000) failed: ENOENT (2)

Summary:
passed   0
failed   0
broken   1
skipped  0
warnings 0


-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220317/73b6adcd/attachment.htm>