[LTP] [PATCH v1] Fix ltp-aiodio tests failing on s390

[Andrea Cervesato]

Hi Petr,

that was missing from the previous implementation indeed. Something that was checked in the other tests, but not this one. Probably because it's also the older test we refactor in the aiodio testing suite. It seems related to the bug and the volatile variable, so I added it as well.

Andrea

On 5/20/22 09:30, Petr Vorel wrote:
> Hi Andrea,
>
>> --- a/testcases/kernel/io/ltp-aiodio/dio_append.c
>> +++ b/testcases/kernel/io/ltp-aiodio/dio_append.c
>> @@ -19,7 +19,7 @@
>>  #include "tst_test.h"
>>  #include "common.h"
>> -static int *run_child;
>> +static volatile int *run_child;
>>  static char *str_numchildren;
>>  static char *str_writesize;
>> @@ -49,7 +49,10 @@ static void setup(void)
>>  static void cleanup(void)
>>  {
>> -	SAFE_MUNMAP(run_child, sizeof(int));
>> +	if (run_child) {
>> +		*run_child = 0;
>> +		SAFE_MUNMAP((void *)run_child, sizeof(int));
>> +	}
> nit: This looks like unrelated, right? If yes it could be in separate commit.
> But I'm ok to merge it in single commit.
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> Kind regards,
> Petr
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220520/c9ddc55c/attachment-0001.htm>