[LTP] [PATCH 0/3] fanotify{14,20}: cleanup
Petr Vorel
pvorel@suse.cz
Tue Sep 6 11:26:12 CEST 2022
Hi,
just an example how to further cleanup fanotify tests by using test macros
from include/tst_test_macros.h. This can wait till Amir's FAN_MARK_IGNORE
patchset [1] is merged (unless there is going to be v2).
fanotify20 is an example what I'd address in the code, fanotify14 just
uses newly added TST_EXP_FD_ERRNO() (more cleanup here and actually in
other tests could be done).
I also admit code in include/tst_test_macros.h is a bit hard to read due
being macro. We should probably add some documentation to it.
Kind regards,
Petr
[1] https://lore.kernel.org/ltp/20220905154239.2652169-1-amir73il@gmail.com/
Petr Vorel (3):
tst_test_macros: Add TST_EXP_FD_ERRNO
fanotify20: Simplify code
fanotify14: Use TST_EXP_FD_ERRNO()
include/tst_test_macros.h | 10 ++
.../kernel/syscalls/fanotify/fanotify14.c | 118 +++++-------------
.../kernel/syscalls/fanotify/fanotify20.c | 81 +++---------
3 files changed, 62 insertions(+), 147 deletions(-)
--
2.37.3
More information about the ltp
mailing list